Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example node tests #68

Closed
wants to merge 3 commits into from
Closed

Conversation

mstriemer
Copy link
Contributor

Here's what I was thinking for running the tests in node. Obviously some cleanup is required. We'd have to use the shallow renderer for the basic stuff. I'm not sure what we'd do once we've got redux + fetching setup so maybe this should wait until then. Food for thought I guess.

I was sitting on the code for #62 so I just left it there cause this is pretty small.

@mstriemer
Copy link
Contributor Author

It's probably worth noting that shallow rendering is "experimental".

@muffinresearch
Copy link
Contributor

I'm not sure I understand this. It appears to just run the test via mocha which isn't testing server-side rendering in any way unless there's something I'm missing or there's some magic involved.

@mstriemer
Copy link
Contributor Author

It's actually slower to run the tests in node, probably because of webpack needing to bundle everything. This isn't too useful locally and we might not need it at all.

@mstriemer mstriemer closed this Mar 7, 2016
@mstriemer mstriemer deleted the example-node-tests branch March 7, 2016 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants