Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn amo:dev is the preferred way to develop #7199

Merged
merged 1 commit into from Dec 11, 2018
Merged

yarn amo:dev is the preferred way to develop #7199

merged 1 commit into from Dec 11, 2018

Conversation

kumar303
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Dec 11, 2018 •
edited

Codecov Report

Merging #7199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   mozilla/addons-frontend#7199   +/-   ##
======================================
  Coverage    97.8%   97.8%           
======================================
  Files         254     254           
  Lines        6974    6974           
  Branches     1274    1274           
======================================
  Hits         6821    6821           
  Misses        139     139           
  Partials       14      14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed2ae7...9f2e853. Read the comment docs.

@bobsilverberg bobsilverberg self-assigned this Dec 11, 2018
bobsilverberg
bobsilverberg approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@bobsilverberg bobsilverberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kumar303.

@kumar303 kumar303 merged commit 5092dde into mozilla:master Dec 11, 2018
@kumar303 kumar303 deleted the yarn-amo-docs-7198 branch December 11, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobsilverberg bobsilverberg bobsilverberg approved these changes

@rebmullin rebmullin Awaiting requested review from rebmullin

Assignees

@bobsilverberg bobsilverberg

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kumar303 @codecov-io @bobsilverberg