Redux with stub data (fixes #8) #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const store = createStore(combineReducers({addons, search})); | ||
|
|
||
| const App = () => ( | ||
| <Provider store={store}> |
There was a problem hiding this comment.
This redux stuff normally seems to go in an index.js file but we want to split it out per app. I'm not sure if this is the best place for it but apparently it works.
mstriemer
force-pushed
the
add-redux-8
branch
5 times, most recently
from
280a75f
to
0157809
Compare
| bar: {slug: 'bar', title: 'The bar add-on'}, | ||
| }; | ||
|
|
||
| export default function addon(state = initialState, action) { |
There was a problem hiding this comment.
Would be nice to tweak the style settings so we don have spaces around default args e.g. so we have state=initialState instead of state = initialState.
There was a problem hiding this comment.
Yeah, I found this a little weird at first. I don't totally hate it but not what I went with first.
|
There's conflicts that need addressing but this is looking good. r+wc |
|
I don't see coveralls posting the status anymore, maybe it only does that when the coverage goes down? |
mstriemer
added a commit
that referenced
this pull request
Mar 7, 2016
Redux with stub data (fixes #8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably still needs some cleanup. Fixes mozilla/addons#5583.