Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use setupFilesAfterEnv instead of setupTestFrameworkScriptFile #7509

Merged
merged 1 commit into from Jan 29, 2019
Merged

Use setupFilesAfterEnv instead of setupTestFrameworkScriptFile #7509

merged 1 commit into from Jan 29, 2019

Conversation

willdurand
Copy link
Member

Fixes #7506

@codecov-io
Copy link

codecov-io commented Jan 29, 2019 •
edited

Codecov Report

Merging #7509 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7509   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files         256      256           
  Lines        7037     7037           
  Branches     1312     1312           
=======================================
  Hits         6899     6899           
  Misses        124      124           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc5fe2...10ef407. Read the comment docs.

rebmullin
rebmullin approved these changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@rebmullin rebmullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@willdurand willdurand merged commit 9ef7a6b into master Jan 29, 2019
@willdurand willdurand deleted the fix-config-jest branch January 29, 2019 14:57
suhailsinghbains pushed a commit to suhailsinghbains/addons-frontend that referenced this pull request Jan 30, 2019
@willdurand
Use setupFilesAfterEnv instead of setupTestFrameworkScriptFile (mozil…
660c0c7 
…la#7509)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebmullin rebmullin rebmullin approved these changes

@kumar303 kumar303 Awaiting requested review from kumar303

@bobsilverberg bobsilverberg Awaiting requested review from bobsilverberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@willdurand @codecov-io @rebmullin