Import Firefox 68 schema. #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,7 @@ import bookmarks from './bookmarks.json'; | |||
| import browserAction from './browser_action.json'; | |||
| import browserSettings from './browser_settings.json'; | |||
| import browsingData from './browsing_data.json'; | |||
| import captivePortal from './captive_portal.json'; | |||
There was a problem hiding this comment.
The tests are failing on not being able to find this by the looks of it.
There was a problem hiding this comment.
Indeed, I pushed the missing file in 2d7ccde. Totally forgot 😞
muffinresearch
approved these changes
Jun 4, 2019
There was a problem hiding this comment.
Tests are passing (aside from appveyor), it looks sane - I'm not sure otherwise how to review this as I'm not familiar enough with the incoming changes.
Could you ask QA to ensure they throw plenty of real add-ons through validation to test this in action?
r+wc
Absolutely |
This was referenced Jun 27, 2019
This was referenced Jul 19, 2019
This was referenced Jul 29, 2019
This was referenced Aug 1, 2019
This was referenced Sep 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2623