Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use style attrs for theme images #1323

Closed
muffinresearch opened this issue Jan 12, 2016 · 1 comment
Closed

Don't use style attrs for theme images #1323

muffinresearch opened this issue Jan 12, 2016 · 1 comment

Comments

@muffinresearch
Copy link
Contributor

Relates to mozilla/addons#1660

To avoid needing unsafe-inline for style-src we need to remove that from themes where it's used.

This can be either to use a img element + some CSS

or

Use style props directly (not the style attr) via jquery.css() and use a data-attr for the img src.

Needs checking on details pages and any other places the themes are presented.

@muffinresearch
Copy link
Contributor Author

Closing this - we're not going to be able to do it because there's tons of inline style attrs in libs and plugins. As a result I think we'll leave unsafe-inline for style-src for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant