Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The hero endpoint needs to return promoted for the addon #8004

Closed
bobsilverberg opened this issue Oct 15, 2020 · 2 comments · Fixed by mozilla/addons-server#15764
Closed

The hero endpoint needs to return promoted for the addon #8004

bobsilverberg opened this issue Oct 15, 2020 · 2 comments · Fixed by mozilla/addons-server#15764
Assignees
@eviljeff
Labels
component:api repository:addons-server Issue relating to addons-server state:verified_fixed
Milestone
2020.10.22

Comments

@bobsilverberg
Copy link
Contributor

In order to support #13853, we need to have access to the promoted property in the addon in the API response to the hero endpoint, but unfortunately that is not currently available.
@bobsilverberg bobsilverberg mentioned this issue Oct 15, 2020
Merged
@bobsilverberg
Copy link
Contributor Author

I'm bumping this up to a P2 as it blocks #13853, and hence the feature. Do you think you'll have time to take this on @eviljeff?

@eviljeff eviljeff self-assigned this Oct 19, 2020
@eviljeff eviljeff added this to the 2020.10.22 milestone Oct 19, 2020
@eviljeff eviljeff mentioned this issue Oct 19, 2020
Merged
@ioanarusiczki
Copy link

@eviljeff The endpoint https://addons-dev.allizom.org/api/v4/hero/primary/ returns the promoted property for addons.

"promoted": {
"apps": [
"firefox"
],
"category": "recommended"

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eviljeff eviljeff

Labels
component:api repository:addons-server Issue relating to addons-server state:verified_fixed
Projects
None yet
Milestone
2020.10.22
Development

Successfully merging a pull request may close this issue.

exposed promoted in primary hero api addon object eviljeff/olympia
4 participants
@bobsilverberg @eviljeff @KevinMind @ioanarusiczki