Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set min version compatibility for mv3 addons #17473

Closed
eviljeff opened this issue Jul 12, 2021 · 3 comments · Fixed by #17635
Closed

set min version compatibility for mv3 addons #17473

eviljeff opened this issue Jul 12, 2021 · 3 comments · Fixed by #17635

Comments

@eviljeff
Copy link
Member

We want to set a minimum version compatibility for add-ons that use manifest version 3, equal to the version of Firefox that supports it. (Need a target version of Firefox, or a guess for now - won't matter if it moves until we enable the submission switch)

@mixedpuppy want to estimate a target release? 98?

@eviljeff eviljeff added this to To do in Add-ons Q3 2021: Mv2 to MV3 support via automation Jul 12, 2021
@eviljeff eviljeff self-assigned this Aug 3, 2021
@eviljeff
Copy link
Member Author

eviljeff commented Aug 3, 2021

Going with Firefox 100 but we can change this closer to the launch (i.e. when the waffle switch is enabled)

@eviljeff eviljeff moved this from To do to In progress in Add-ons Q3 2021: Mv2 to MV3 support Aug 3, 2021
@eviljeff eviljeff added this to the 2021.08.12 milestone Aug 3, 2021
Add-ons Q3 2021: Mv2 to MV3 support automation moved this from In progress to Done Aug 3, 2021
@eviljeff
Copy link
Member Author

eviljeff commented Aug 4, 2021

QA: I'm not sure how testable this is on addons-dev this far in advance - Firefox 100 won't have been added as a version yet...? Interested to know what happens though!

@AlexandraMoga
Copy link

@eviljeff here are a few of the test scenarios I've tried on -dev (btw, new firefox versions can be added via the applications api)

  • MV3 extension without compatibility set in the manifest => defaults to min 100.0 - max * in devhub manage versions page
  • MV3 extension - with compatibility <100 set in the manifest => defaults to min 100.0 - max * in devhub manage versions page
  • MV3 extension - with compatibility >100 set in the manifest => same compatibility threshold is displayed in devhub after submission - for example min 110.0 - max 110.* if this is what the manifest specifies
  • MV2 extension without compatibility set in the manifest => defaults to min 48.0 - max * in devhub manage versions page
  • MV2 extension with compatibility <100 set in the manifest => compatibility specified in the manifest is displayed in devhub after submission
  • MV2 extension with compatibility >100 set in the manifest => same compatibility threshold is displayed in devhub after submission - for example min 110.0 - max 110.*
  • MV3 language pack compatibility in manifest set to min 100.0 - max 100.* => compatibility specified in the manifest is displayed in devhub after submission
  • MV3 language pack with compatibility <100 set in the manifest => defaults to min 100.0 - max 100.0 in devhub manage versions page
  • MV2 language pack with compatibility <100 set in the manifest => compatibility specified in the manifest is displayed in devhub after submission

The results seem to be as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants