Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit ADD_RATING for developer replies too (or a specific one) #9039

Closed
diox opened this issue Jan 11, 2023 · 4 comments · Fixed by mozilla/addons-server#20689
Closed

Emit ADD_RATING for developer replies too (or a specific one) #9039

diox opened this issue Jan 11, 2023 · 4 comments · Fixed by mozilla/addons-server#20689

Comments

@diox
Copy link
Member

diox commented Jan 11, 2023

For new ratings replies, we don't emit an ActivityLog:

https://github.com/mozilla/addons-server/blob/d338d271d92c400887f1e3ccf6aea6488cb4d5dc/src/olympia/ratings/models.py#L290-L295

I've added a comment when I refactored the code a few years ago now, but this has always been the case. There is no good reason though, we might be interested in tracking this as well. Possibly through a different activity class to differentiate easily between regular ratings and replies.

┆Issue is synchronized with this Jira Task

@GregSherman
Copy link

Requesting assignment @diox. Also, I've noticed that as a non-dev user that I cannot reply to user reviews nor developer responses to my review, so the only case where a reply_to can exist is if it is from a developer? Or are there any other cases?

@diox
Copy link
Member Author

diox commented May 11, 2023

Correct, the only case where we can have a reply is from developers replying to one of their users.

@ioanarusiczki
Copy link

@GregSherman @eviljeff

I verified this in admin -dev -> /models/activity/activitylog/

I see the developer replies being registered

developer reply

I've also noticed what Greg wrote here .

I'll mark this verified.

@KevinMind
Copy link
Contributor

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants