add logging for review replies + test #20689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviljeff
requested changes
May 15, 2023
|
With dev replies, there is no log for deleting them. If a dev deletes a reply and then re-replies to that same comment, it's considered an edit, is this normal behaviour? |
It's a little unintuitive I agree, but the reasoning is that we a) want to keep deleted replies in general, but b) want at most 1 reply per rating, so a reply would just edit (and undelete) the instance. |
|
btw, you've got a conflict now because mat just landed a patch that also added an activity action - he's taken id=142 |
Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 4.22.3 to 4.23.0. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py) - [Commits](protocolbuffers/protobuf@v4.22.3...v4.23.0) --- updated-dependencies: - dependency-name: protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Quế Tùng <best.cloney.1301@gmail.com> Co-authored-by: Cát Thành <catthanh192@gmail.com>
Co-authored-by: Quế Tùng <best.cloney.1301@gmail.com>
Co-authored-by: Selim Şumlu <selim@sum.lu> Co-authored-by: Grk <gu0townkg@relay.firefox.com>
Co-authored-by: Balázs Meskó <meskobalazs@mailbox.org>
Co-authored-by: Théo Chevalier <theochevalier@pm.me>
Co-authored-by: h8211147g <h8211147g@outlook.com>
Co-authored-by: Michele Rodaro <michele.rodaro@mozillaitalia.org>
Co-authored-by: Michele Rodaro <michele.rodaro@mozillaitalia.org>
Co-authored-by: Francesco Lodolo [:flod] <flod+pontoon@mozilla.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ozilla#20688) * Record why a version was flagged for human review when that happens
Bumps [terser](https://github.com/terser/terser) from 5.17.1 to 5.17.3. - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](terser/terser@v5.17.1...v5.17.3) --- updated-dependencies: - dependency-name: terser dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lan Glad <upwinxp@gmail.com>
|
there's still a conflict |
eviljeff
requested changes
May 16, 2023
eviljeff
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9039
Remove the blocking of ADD_RATING logging for review replies. Update the associated test name & assertion.