Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for versionRange in graphics blocklists #3273

Closed
jvillalobos opened this issue Jul 6, 2016 · 8 comments · Fixed by mozilla/addons-server#3099
Closed

Add support for versionRange in graphics blocklists #3273

jvillalobos opened this issue Jul 6, 2016 · 8 comments · Fixed by mozilla/addons-server#3099
Assignees
Labels
repository:addons-server Issue relating to addons-server

Comments

@jvillalobos
Copy link

I learned from bug 1283601 that there's a new attribute in graphics blocklist entries that needs to be supported in our admin interface. It's necessary in order to resolve that bug, so it can't wait for the move to kinto.

What we need is for gfx entries to have two additional text fields: Max application version, Min application version. They should both be optional. If either has a value, the versionRange node should be added as a child of the gfxBlacklistEntry, like in these examples:

<versionRange maxVersion="49.9" />
<versionRange minVersion="40.0a1" />
<versionRange minVersion="48.0.2" maxVersion="49.*" />

cc @n1k0 for the kinto side of this.

@n1k0
Copy link

n1k0 commented Jul 6, 2016

I've filed mozilla-services/amo2kinto#39 about this.

@andymckay
Copy link

Sorry @EnTeQuAk would you have time to look at this?

@EnTeQuAk
Copy link
Contributor

eh, I tried to duck away but I guess I'll take a look at it asap 😆

@EnTeQuAk
Copy link
Contributor

@n1k0 @Natim should I add support for this in gfxs_to_json while I'm at it or do you do that once you're working on the Kinto side?

@n1k0
Copy link

n1k0 commented Jul 14, 2016

@EnTeQuAk that'd be helpful yes, thanks!

Note: we're both off today and tomorrow (14th of July in France + PTO)

@EnTeQuAk
Copy link
Contributor

@N10K I added support for the versionRange into the json serialization too. Let me know if that works properly :)

@Natim
Copy link

Natim commented Jul 18, 2016

@EnTeQuAk do you know if we can have a gfx_item configured with versionRange in dev to test it?

@EnTeQuAk
Copy link
Contributor

We do, it's on dev, stage and prod so feel free to configure it or let me know on IRC if I should prepare something.

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants