-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for versionRange in graphics blocklists #3273
Comments
I've filed mozilla-services/amo2kinto#39 about this. |
Sorry @EnTeQuAk would you have time to look at this? |
eh, I tried to duck away but I guess I'll take a look at it asap 😆 |
@EnTeQuAk that'd be helpful yes, thanks! Note: we're both off today and tomorrow (14th of July in France + PTO) |
This is needed to support https://bugzilla.mozilla.org/show_bug.cgi?id=1283601 Fixes #3054
…blocklist This is needed to support https://bugzilla.mozilla.org/show_bug.cgi?id=1283601 Fixes #3054
@N10K I added support for the versionRange into the json serialization too. Let me know if that works properly :) |
@EnTeQuAk do you know if we can have a gfx_item configured with versionRange in dev to test it? |
We do, it's on dev, stage and prod so feel free to configure it or let me know on IRC if I should prepare something. |
I learned from bug 1283601 that there's a new attribute in graphics blocklist entries that needs to be supported in our admin interface. It's necessary in order to resolve that bug, so it can't wait for the move to kinto.
What we need is for gfx entries to have two additional text fields: Max application version, Min application version. They should both be optional. If either has a value, the
versionRange
node should be added as a child of thegfxBlacklistEntry
, like in these examples:<versionRange maxVersion="49.9" />
<versionRange minVersion="40.0a1" />
<versionRange minVersion="48.0.2" maxVersion="49.*" />
cc @n1k0 for the kinto side of this.
The text was updated successfully, but these errors were encountered: