Hide unreviewed versions (if there is at least one reviewed version) on the 'all versions' page

[kuremu]

Describe the problem and steps to reproduce it:

Vimperator version (3.15.0) is linking to a missing page.

To reproduce go to https://addons.mozilla.org/en-US/firefox/addon/vimperator/versions/ and click on "Continue to Download" for version 3.15.0

What happened?

404

What did you expect to happen?

A download link for the new version

Anything else we should know?

[wagnerand]

This version has not been approved yet. The download button is different, but we should probably add additional info or hide unreviewed versions from that page.

@jvillalobos Any objections on hiding unreviewed versions (if there is at least one reviewed version) on the 'all versions' page?

[EnTeQuAk]

Hmm, curious if this is a duplicate of #3639?

[jvillalobos]

I'm in favor of hiding them. It's consistent with what we want to do in #3348.

[kuremu]

@wagnerand I'm sure I have downloaded unreviewed versions like this in the past, hence the confusion.

[ValentinaPC]

Verified on AMO-dev FF50.1(Win 7)

• Unreviewed versions are not listed in all versions page
  
  

• Beta version (from beta channel)- automatically reviewed and signed - is listed in all versions development channel page under the text "Caution: Development versions of this add-on have not been reviewed by Mozilla."
  

@diox : From what you said yesterday on irc I understood that beta versions are also not listed in public pages - is this correct?
And second - by who are the beta version reviewed, if not "by Mozilla"?
Thanks!

[diox]

correct, in a way : beta versions are not listed in the "regular" version list, they are listed on the development channel versions list instead.

beta versions are not reviewed, they are automatically signed.

[ValentinaPC]

Based on the previous 2 comments I'll mark this as fixed.

[jvillalobos]

Actually, we do want to show beta versions on the All Versions page. There's a link from listing pages (in the Developer Channel section) pointing to the All Versions page so you can see previous beta versions. I don't know if this should be reopened or a new issue should be filed, since it's already live.

[jvillalobos]

Never mind. I just realized that, in this particular case I was looking at, there are two links pointing to the different version list pages.

The compatibility warning box has a View other versions link that points to the normal All Versions page. I suppose we can live with that situation for now.