Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the (AMO) and (Self) tags aren't localised #4398

Closed
eviljeff opened this issue Jan 18, 2017 · 6 comments
Closed

the (AMO) and (Self) tags aren't localised #4398

eviljeff opened this issue Jan 18, 2017 · 6 comments
Assignees
Milestone

Comments

@eviljeff
Copy link
Member

We show (AMO) and (Self) next to versions in a few places if an addon has both unlisted and listed versions. But the text isn't localised.

@eviljeff
Copy link
Member Author

@jvillalobos can you weigh in to confirm if 'Self' should be localised - I'm guessing 'AMO' not.

@jvillalobos
Copy link
Contributor

They are meant to be compact tags, so I would favor keeping them hardcoded as Self and AMO. But perhaps they should have a localized tooltip that explains their meaning.

@eviljeff
Copy link
Member Author

Can you provide copy for the tooltips? Also, can you mockup what you want it to look like - if not the standard (?) circle then what?

@eviljeff
Copy link
Member Author

@jvillalobos ^

@jvillalobos
Copy link
Contributor

  • AMO: "Listed on this site after passing code review. Automatic updates are handled by this site."
  • Self: "Signed for self-distribution. Updates are handled by you."

As for the look, I think we should keep it consistent with the rest of the dev hub and use the blue popup with white text. The only difference is that the popup would emerge from the tag rather than a separate (?) circle.
tooltip

@ValentinaPC
Copy link

Verified as fixed on AMO-dev FF50(Win 7)
Postfix screenshots:
amotooltip
selftooltip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants