Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta add-on asking for resume after deleting first listed version #4427

Closed
ValentinaPC opened this issue Jan 20, 2017 · 3 comments
Closed

Beta add-on asking for resume after deleting first listed version #4427

ValentinaPC opened this issue Jan 20, 2017 · 3 comments
Assignees

Comments

@ValentinaPC
Copy link

ValentinaPC commented Jan 20, 2017

Steps to reproduce:

  1. Submit a listed add-on and approve it (i.e. https://addons-dev.allizom.org/en-US/developers/addon/test-webext-secondbeta/edit)
  2. Submit a second beta version for the submitted add-on
  3. Delete the listed version
  4. Go to "My Submissions" page and see your add-on status

Expected results:
The add-on has a status (maybe "Incomplete"?).

Actual results:
The add-on has 2 links: Resume and Delete together with the message "This add-on will be deleted automatically after a few days if the submission process is not completed."

Notes/Issues:

  • Using the direct manage link for the submitted addon i.e. https://addons-dev.allizom.org/en-US/developers/addon/test-webext-secondbeta/edit the add-on status is "Incomplete".
  • if the listed version is only disabled the add-on is listed as "Incomplete"
  • Beside the "Listed version" text from manage page is displayed the beta version number - which is a bit confusing.
    Verified on FF50(Win 7). Issue is reproducing on AMO-dev and -stage.
    Screenshots for this issue:
    manage
    mysubm
@eviljeff
Copy link
Member

Currently what happens in this scenario is the Addon stops being Approved, because it has no Approved listed versions, but it does have a listed version (the beta version) so it's status is Incomplete and shown as such.
The 'listed version' is shown as 1.1b as a beta version stops being treated as a beta version for latest version purposes because only Approved Addons can have a beta channel.

(It's all a bit muddled because beta versions are a type of listed version, rather than an explicit extra channel.)

@ValentinaPC
Copy link
Author

Verified on AMO-dev FF51(Win 7) and obtained the following results:

  • Add-on status: Incomplete
  • Info message displayed in "Manage My Submissions" page
  • adding an unlisted version will add an AMO label near the Beta version
  • adding a listed version will turn add-on status to "normal"
    Screenshots:
    manage_pg
    mysubmission
    amo-label

@diox : If this is how it suppose to look, I'll mark this verified. Thanks!

@diox
Copy link
Member

diox commented Feb 8, 2017

Yep, that's it. We could do better in the versions page but I focused on making the message in the add-on list correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants