Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a desktop "all reviews" page #10472

Closed
tofumatt opened this issue Jun 13, 2017 · 12 comments
Closed

Implement a desktop "all reviews" page #10472

tofumatt opened this issue Jun 13, 2017 · 12 comments
Assignees
Labels
Milestone

Comments

@tofumatt
Copy link
Contributor

Implement the review page for desktop, relates to #3045.

@tofumatt
Copy link
Contributor Author

It turns out there isn't a mock for this in the mocks... maybe it was overlooked?

@pwalm Can you confirm there's no desktop version of "all reviews" (after the list that's on the details page)? No worries if not, the mobile will work okay, just want to confirm I'm not missing it in the mocks.

@pwalm
Copy link
Contributor

pwalm commented Jul 12, 2017

I am missing it, but it won't be hard to throw together. Kind of a hectic week, can I have it to you by Friday?

@tofumatt
Copy link
Contributor Author

tofumatt commented Jul 12, 2017 via email

@tofumatt
Copy link
Contributor Author

tofumatt commented Aug 4, 2017

Arg, I thought I updated this issue with the image but I must've not clicked submit. Here's the mock from @pwalm:

all reviews page - 1366px

@kumar303
Copy link
Contributor

kumar303 commented Aug 4, 2017

Is there an API bug on file to get a tally of ratings grouped by star count? We do not currently have this data: http://addons-server.readthedocs.io/en/latest/topics/api/addons.html#get--api-v3-addons-addon-(int-id|string-slug|string-guid)-

@kumar303
Copy link
Contributor

kumar303 commented Aug 17, 2017

Here is the API issue for exposing counts grouped by star: #4678 It's not a strict blocker because the rest of the page can be rendered until the star count API is ready.

@kumar303
Copy link
Contributor

whoops, we already have the grouped rating data in the API: http://addons-server.readthedocs.io/en/latest/topics/api/reviews.html#list-reviews

@ValentinaPC
Copy link

Verified All Review page in AMO-dev FF56(Win 7) and this is how it looks like now:
2017-10-27_1227

@tofumatt : Looks like mocks and actual page are very different. Is there an intend to implement those options? Or this is how it should look like? Thanks a lot!

@pwalm
Copy link
Contributor

pwalm commented Oct 27, 2017

Should look like this:
screen shot 2017-10-27 at 12 26 43 pm

@ValentinaPC
Copy link

But, it looks like this:
2017-10-30_1046

@ValentinaPC ValentinaPC reopened this Oct 30, 2017
@tofumatt
Copy link
Contributor Author

tofumatt commented Oct 30, 2017 via email

@ValentinaPC
Copy link

We can mark this as verified-fixed, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants