-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a desktop "all reviews" page #10472
Comments
It turns out there isn't a mock for this in the mocks... maybe it was overlooked? @pwalm Can you confirm there's no desktop version of "all reviews" (after the list that's on the details page)? No worries if not, the mobile will work okay, just want to confirm I'm not missing it in the mocks. |
I am missing it, but it won't be hard to throw together. Kind of a hectic week, can I have it to you by Friday? |
Oh gosh yeah that's fine. No rush at all, this Friday or even the next one is fine.
Matthew Riley MacPherson
… On 12 Jul 2017, at 04:28, Philip ***@***.***> wrote:
I am missing it, but it won't be hard to throw together. Kind of a hectic week, can I have it to you by Friday?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Arg, I thought I updated this issue with the image but I must've not clicked submit. Here's the mock from @pwalm: |
Is there an API bug on file to get a tally of ratings grouped by star count? We do not currently have this data: http://addons-server.readthedocs.io/en/latest/topics/api/addons.html#get--api-v3-addons-addon-(int-id|string-slug|string-guid)- |
|
whoops, we already have the grouped rating data in the API: http://addons-server.readthedocs.io/en/latest/topics/api/reviews.html#list-reviews |
feat: Improve Ratings on desktop (fix #2564)
Verified All Review page in AMO-dev FF56(Win 7) and this is how it looks like now:
@tofumatt : Looks like mocks and actual page are very different. Is there an intend to implement those options? Or this is how it should look like? Thanks a lot! |
|
The write a review button is part of a new flow and should be a separate bug then. Because most of the work here is done and changing that review flow with the new button will be its own issue :-)
- Matthew Riley MacPherson
tofumatt.com
… On 30 Oct 2017, at 08:51, ValentinaPC ***@***.***> wrote:
Reopened mozilla/addons#3051.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
We can mark this as verified-fixed, then. |
Implement the review page for desktop, relates to #3045.
The text was updated successfully, but these errors were encountered: