Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor report abuse form to use DismissibleTextForm #10834

Closed
kumar303 opened this issue Sep 29, 2017 · 4 comments · Fixed by mozilla/addons-frontend#7382
Closed

Refactor report abuse form to use DismissibleTextForm #10834

kumar303 opened this issue Sep 29, 2017 · 4 comments · Fixed by mozilla/addons-frontend#7382

Comments

@kumar303
Copy link
Contributor

kumar303 commented Sep 29, 2017

Part of the report abuse form was extracted into a reusable component. It landed in #10833

The ReportAbuseButton component should now use DismissibleTextForm. Take a look at ReportUserAbuse for an example of how to do the conversion.

For QA:

  • go to an add-on detail page
  • click Report Abuse
  • make sure the abuse report form still works
@willdurand
Copy link
Member

Bumping priority because other components use auto-save, so it'd be nice to have auto-save for that too.

@mirefly
Copy link

mirefly commented Jan 11, 2019

I am trying to refactor ReportAbuseButton using DismissibleTextForm. I found that the buttons for "report abuse" and "report user abuse" are different. Do you want to keep the "report abuse" button looks the same as before (red submit button) or being consistent with "report user abuse" button (blue submit button) ? The later one actually will be a bit easier, since no need to change style sheets much.

image

image

@kumar303
Copy link
Contributor Author

Yes, they were designed at different times. I would suggest making it look consistent with 'report user abuse' because that one uses newer button styles.

@ioanarusiczki
Copy link

@kumar303 @willdurand
Report user for abuse works as before and the new design is available - verified on AMO dev and AMO stage FF64 (Win10 & Android 8.0).

AMO stage - new design

new design

AMO prod - old design which is going to be replaced

old design reporting

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants