Refactor ReportAbuseButton to use DismissibleTextForm #7382
Conversation
Codecov Report
@@ Coverage Diff @@
## master mozilla/addons-frontend#7382 +/- ##
==========================================
- Coverage 97.87% 97.86% -0.01%
==========================================
Files 257 257
Lines 7044 7024 -20
Branches 1302 1299 -3
==========================================
- Hits 6894 6874 -20
Misses 136 136
Partials 14 14
Continue to review full report at Codecov.
|
| // We need to use mount here because we're interacting with refs. (In | ||
| // this case, the textarea.) | ||
| const root = renderMount(); |
There was a problem hiding this comment.
Is the comment above still accurate? We could maybe use shallow instead of mount here now.
There was a problem hiding this comment.
I agree the comment is not accurate any more. I tried shallow, but it seems that I need to call renderShallow again to make the expect line works. I am not sure why it does not rerender. If calling renderShallow twice is ok, I will change it to shallow.
let root = renderShallow({ addon, store });
root.find(Button).simulate('click', fakeEvent)
root = renderShallow({ addon, store });
expect(root.find('.ReportAbuseButton--is-expanded')).toHaveLength(1);
There was a problem hiding this comment.
what if you call root.update() instead?
There was a problem hiding this comment.
Neither of root.update() / root.instance().forceUpdate() works. It looks like root (<ReportAbuseButtonBase/>) cannot get the updated props value from <ReportAbuseButton>. It might be related to enzymejs/enzyme#1229 (comment)
I found some other tests using render twice.
There was a problem hiding this comment.
I see. let's keep it as is then
|
Hi @mirefly, it looks like you resolved all comments but you did not push any update yet. |
|
@willdurand Thanks very much for help on this. I pushed the changes. |
mirefly
force-pushed
the
refactor-report-abuse-form-3279
branch
from
e529f44
to
adbd48f
Compare
mirefly
force-pushed
the
refactor-report-abuse-form-3279
branch
from
adbd48f
to
c7eded3
Compare
|
Thanks @mirefly! |
Fixes mozilla/addons#10834
Botton styles changes.
I also removed relevant part of
disableAbuseButtonUIandenableAbuseButtonUIin "core/reducers/abuse.js" since they are not used any more.Before,
After,
