Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The versions notes are cut on the version page when a long unbroken string is used #13751

Closed
ioanarusiczki opened this issue May 20, 2020 · 5 comments · Fixed by mozilla/addons-frontend#9440
Closed

The versions notes are cut on the version page when a long unbroken string is used #13751

ioanarusiczki opened this issue May 20, 2020 · 5 comments · Fixed by mozilla/addons-frontend#9440
Assignees
@willdurand
Labels
contrib:maybe_good_first_bug repository:addons-frontend Issue relating to addons-frontend state:verified_fixed
Milestone
2020.05.28

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented May 20, 2020 •
edited
Loading

As a followup for #13356

STR:

  1. I edited the release notes for a version adding a long unbroken string. The version page looks like:
    https://addons.allizom.org/en-US/firefox/addon/search_by_image/versions/?src=rating

versionnotes

I tested on FF76(Win10).
When resizing, at ~600 width the text is entirely visible.
@ioanarusiczki ioanarusiczki mentioned this issue May 20, 2020
Closed
@bobsilverberg
Copy link
Contributor

This is similar to #13750. It's probably just a simple css fix, but not a high priority as it's unlikely that the release notes for a version would contain a long unbroken string in the wild.

@willdurand willdurand self-assigned this May 22, 2020
willdurand referenced this issue in mozilla/addons-frontend May 22, 2020
@willdurand
Use overflow-wrap: anywhere, everywhere
7286759 
Fixes https://github.com/mozilla/addons-frontend/issues/9433

Fixes https://github.com/mozilla/addons-frontend/issues/9432

Fixes https://github.com/mozilla/addons-frontend/issues/9436
@willdurand willdurand mentioned this issue May 22, 2020
Merged
@willdurand willdurand added this to the 2020.05.28 milestone May 22, 2020
@ioanarusiczki
Copy link
Author

@willdurand This is still reproducible. Please take a look: https://addons.allizom.org/en-US/firefox/addon/search_by_image/versions/

@willdurand
Copy link
Member

@willdurand This is still reproducible. Please take a look: addons.allizom.org/en-US/firefox/addon/search_by_image/versions

@ioanarusiczki mm would you have a link in -dev?

@ioanarusiczki
Copy link
Author

@willdurand Oh, I went straight to AMO stage :)) Sorry! Brb!

@ioanarusiczki
Copy link
Author

ioanarusiczki commented May 26, 2020 •
edited
Loading

@willdurand Verified on AMO dev with FF76(Win10).
Sorry once again. I was awake but I wasn't on coffee this morning.

fixed

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willdurand willdurand

Labels
contrib:maybe_good_first_bug repository:addons-frontend Issue relating to addons-frontend state:verified_fixed
Projects
None yet
Milestone
2020.05.28
Development

Successfully merging a pull request may close this issue.

Use overflow-wrap: anywhere, everywhere mozilla/addons-frontend
4 participants
@bobsilverberg @willdurand @KevinMind @ioanarusiczki