Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage layout issue when long unbroken strings are used for the recommended addons #13750

Closed
ioanarusiczki opened this issue May 20, 2020 · 2 comments · Fixed by mozilla/addons-frontend#9440
Closed

Homepage layout issue when long unbroken strings are used for the recommended addons #13750

ioanarusiczki opened this issue May 20, 2020 · 2 comments · Fixed by mozilla/addons-frontend#9440
Assignees
@willdurand
Labels
contrib:maybe_good_first_bug repository:addons-frontend Issue relating to addons-frontend state:verified_fixed
Milestone
2020.05.28

Comments

@ioanarusiczki
Copy link

Followup for #13356

  1. It may seem that Layout issues in the primary hero caused by unbroken strings #13418 regressed
    There's a layout issue when the name and description is a longer unbroken string on Homepage.
    I tested with FF76(Win10).

regression nr 1
@ioanarusiczki ioanarusiczki mentioned this issue May 20, 2020
Closed
@bobsilverberg
Copy link
Contributor

We should fix this. It's not a very high priority as we are in control of what goes into that field, and I cannot imagine an administrator adding a long unbroken text string.

This is likely just a one-line css change, so I think it's a decent candidate for a good first bug.

This was referenced May 20, 2020
Closed
Closed
@willdurand willdurand self-assigned this May 22, 2020
@willdurand willdurand added this to the 2020.05.28 milestone May 22, 2020
willdurand referenced this issue in mozilla/addons-frontend May 22, 2020
@willdurand
Use overflow-wrap: anywhere, everywhere
7286759 
Fixes https://github.com/mozilla/addons-frontend/issues/9433

Fixes https://github.com/mozilla/addons-frontend/issues/9432

Fixes https://github.com/mozilla/addons-frontend/issues/9436
@willdurand willdurand mentioned this issue May 22, 2020
Merged
@ioanarusiczki
Copy link
Author

@willdurand

Verified on AMO dev with FF76(Win10).

long stringfix1

@KevinMind KevinMind added migration:no-jira repository:addons-frontend Issue relating to addons-frontend labels May 5, 2024
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willdurand willdurand

Labels
contrib:maybe_good_first_bug repository:addons-frontend Issue relating to addons-frontend state:verified_fixed
Projects
None yet
Milestone
2020.05.28
Development

Successfully merging a pull request may close this issue.

Use overflow-wrap: anywhere, everywhere mozilla/addons-frontend
4 participants
@bobsilverberg @willdurand @KevinMind @ioanarusiczki