Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pinning of isort when possible #13775

Closed
bobsilverberg opened this issue Jul 7, 2020 · 1 comment · Fixed by mozilla/addons-frontend#9510
Closed

Remove pinning of isort when possible #13775

bobsilverberg opened this issue Jul 7, 2020 · 1 comment · Fixed by mozilla/addons-frontend#9510
Labels
component:code_quality migration:no-jira migration:2024 qa:not_needed repository:addons-frontend Issue relating to addons-frontend

Comments

@bobsilverberg
Copy link
Contributor

We had to add a pinning of isort to tests/ui/requirements/flake8.txt in order to fix a build failure, but we should be able to remove it once gforcada/flake8-isort#89 lands and a new version is released.
@bobsilverberg bobsilverberg mentioned this issue Jul 7, 2020
Merged
@willdurand
Copy link
Member

Looks like the upstream lib was fixed last night: gforcada/flake8-isort#89

@bobsilverberg bobsilverberg mentioned this issue Jul 8, 2020
Merged
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:code_quality migration:no-jira migration:2024 qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump the version of flake8-isort, remove pinning of isort bobsilverberg/addons-frontend
3 participants
@bobsilverberg @willdurand @KevinMind