Pin major version of all dependencies #89
Conversation
|
Thanks for the issue and PR and even the comments to make things even better! I'm using I will try to take some time within this week to move towards a pip-tools solution and get a release, if someone updates this PR or creates a new one, please be my guests, family time (with two kids) and work don't give much free time 😅 |
|
Oh, but thanks @pkolbus for taking a stab at fixing it! 🙇 let's make it even better with what others have also commented! 👍 |
Under Semantic Versioning (common for Python packages), breaking API changes can occur in a major version update. This has happened with isort 5 and could happen with any other package that flake8-isort uses.
|
@gforcada, thanks for your perspective. The most urgent part of this PR is the I'm happy to help out with the pip-tools approach, but a bit skittish about making a more complex change when Travis CI isn't getting far enough to actually exercise it -- so I think getting Travis passing again comes next. I'll see about getting PRs for both. |
pkolbus
force-pushed
the
issue-88-pin-dependencies
branch
from
5da7513
to
b1f831c
Compare
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
|
And 3.0.1 is released! 🎉 |
|
Thanks for everyone that help pushing the fix! 🙇 |
In .travis.yml, the versions of coveralls and pytest-cov were unconstrained, creating a risk of failure in Travis CI builds if an incompatible version of pytest-cov or coveralls is released. As suggested in gforcada#89, use pip-tools to address this risk. The dependencies for coverage testing are in requirements-cov.in. The frozen set of packages is in requirements-cov.txt, compiled for python 2.7. This is only for coverage testing, since pip-tools doesn't handle relative paths and a minimal environment can help detect undeclared dependencies.
Under Semantic Versioning (common for Python packages), breaking API changes can occur in a major version update. This has happened with
isort5 and could happen with any other package thatflake8-isortuses.This PR is a workaround for issue #88 to unbreak
flake8-isortusers.