Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon Validation Error #1520

Closed
ntinkler-calendly opened this issue Aug 21, 2023 · 3 comments
Closed

Addon Validation Error #1520

ntinkler-calendly opened this issue Aug 21, 2023 · 3 comments

Comments

@ntinkler-calendly
Copy link

Please attach a copy of your add-on, and fill in the following information:

  • Whether this error occurred during the submission of a new add-on, a new version of an existing add-on, a new file in an existing version, or an upload to the standalone validator.

This is happening during an upload of a new version of an existing add-on.

  • Whether your add-on is listed or unlisted.

Listed

  • The URL where you submitted the add-on.

https://addons.mozilla.org/en-US/developers/addon/calendly-meeting-scheduling/versions/submit/

  • The approximate time you submitted the add-on, with timezone.

10:04 AM, Monday Aug 21st, EDT (GMT-04).

@ntinkler-calendly
Copy link
Author

ntinkler-calendly commented Aug 21, 2023

@ntinkler-calendly
Copy link
Author

ntinkler-calendly commented Aug 21, 2023

My suspicion here is we're bumping up against some resource limit in the validator (We have a large number of heavy js files). The extension loads and runs locally just fine (through about:debugging) and it also validates locally using https://github.com/mozilla/web-ext.

We're planning to split chunks for our JS in the near future, which will cut the package size by about 60% - I'll test another upload after completing those optimizations.

Any feedback or updates on whether this is something we're causing, or a problem upstream would be great, though.

Appreciate any help
-Nate

@wagnerand
Copy link
Member

If you are using a lot of large or complex javascript files, that might be an issue yes. Closing as duplicate of mozilla/addons-linter#4942.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants