Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getDerivedStateFromProps() in UserProfileEdit #2071

Open
willdurand opened this issue Apr 11, 2019 · 4 comments
Open

Use getDerivedStateFromProps() in UserProfileEdit #2071

willdurand opened this issue Apr 11, 2019 · 4 comments
Assignees
@willdurand
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@willdurand
Copy link
Member

willdurand commented Apr 11, 2019 •
edited by data-sync-user

Let's getDerivedStateFromProps() in UserProfileEdit instead of using setState() in componentDidUpdate(). It'll be more future-proof!

For QA: please make sure the edit profile page still works and there is no regression.

┆Issue is synchronized with this Jira Task
@willdurand willdurand mentioned this issue Apr 11, 2019
Merged
@willdurand willdurand self-assigned this Apr 12, 2019
@Shubhamchinda
Copy link

Hey @willdurand , Can I take this?

@willdurand
Copy link
Member Author

Hey @willdurand , Can I take this?

Sorry, that one is not ready for contributors. You can find issues to work on by looking at the opened contrib: welcome issues.

@Shubhamchinda
Copy link

Sorry, that one is not ready for contributors. You can find issues to work on by looking at the opened contrib: welcome issues.

No problem man! 👍

@kplotnik kplotnik reopened this Nov 16, 2022
@KevinMind
Copy link
Contributor

Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDFRNT-165

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 3, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willdurand willdurand

Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@diox @willdurand @KevinMind @Shubhamchinda @kplotnik @data-sync-user