Remove use of componentWillReceiveProps() in UserProfileEdit #7874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#12595
This is similar to other patches.
It is needed to upgrade Enzyme to 3.9.0 which, in turn, should allow us to use
getDerivedStateFromProps()
in this component to get rid of thesetState
calls incomponentDidUpdate()
(there is a known Enzyme issue about that).It is not recommended to use
setState
incomponentDidUpdate()
but it is possible. The only potential problem is infinite loops but we have enough guards in place to avoid that, so I don't think we'll run into issues. That being said, once this patch lands and we upgrade to Enzyme 3.9.0, I'll try to rewrite the logic withgetDerivedStateFromProps()
(cf. mozilla/addons#2071).