Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox's own Dark Mode setting not honoured by AMO - blindingly bright background #2193

Open
Jackalaq opened this issue Oct 2, 2023 · 7 comments
Labels
repository:addons-frontend Issue relating to addons-frontend

Comments

@Jackalaq
Copy link

Jackalaq commented Oct 2, 2023

As description. Dark Mode is selected in Settings and even with Dark Reader AddOn installed, the page is disturbingly bright.

Firefox for Linux Mint

Version 115

┆Issue is synchronized with this Jira Task

@nekohayo
Copy link

nekohayo commented Oct 6, 2023

At least the about:addons UI does follow Firefox's automatic light/dark system theme; it would make a lot of sense for the addons.mozilla.org website to follow suit.

@willdurand
Copy link
Member

Extensions do not run on AMO, for security reasons. And AMO doesn't have a dark mode style for the moment.

@nekohayo
Copy link

I think the OP mentioning the "Dark Reader add-on" was a mistake (i.e.: the key word was "even with"), and they probably primarily intended (as I did) this ticket to be a request for AMO to have a dark mode style, that would get activated by the browser's native prefers-color-scheme: dark; transmission mechanism for the OS' dark mode.

Is this the correct issue tracker for stylesheet issues of AMO? (I presume I landed here because I couldn't find this in Bugzilla)

@diox
Copy link
Member

diox commented Dec 13, 2023

I agree this is a valid issue. (edit: and I've transferred it to a more fitting place but this was the right place to file it, thanks!)

@diox diox reopened this Dec 13, 2023
@diox diox transferred this issue from mozilla/addons Dec 13, 2023
@KevinMind
Copy link
Contributor

@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 3, 2024
@KevinMind KevinMind added repository:addons-frontend Issue relating to addons-frontend migration:2024 labels May 3, 2024
@i1li
Copy link

i1li commented Jun 5, 2024

The year is 2024, why does mozilla block the most basic of accessibility options, choosing instead a path of able-bodied supremacism, and white supremacism? Vision sensitivity isn't an obscure issue, does mozilla even have a dev team? Heres an example of how to honor user accessibility preferences with just a few lines of code, happy to assist with implementation: https://github.com/i1li/i1li.github.io/blob/ed2f57e824a8ad15dba59b5c4217dd06f9e1a8b2/js/script.js#L35

@diox
Copy link
Member

diox commented Jun 5, 2024

AMO team is small and we have a limited bandwidth, we simply can't do everything. The good news is that this is open-source, so if you want to contribute a patch, feel free to submit a pull request over at https://github.com/mozilla/addons-frontend/pulls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

No branches or pull requests

7 participants