Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add-on visibility box and status sidebar for Listed and Unlisted versions #3483

Closed
jvillalobos opened this issue Sep 9, 2016 · 8 comments · Fixed by mozilla/addons-server#4045
Assignees
Labels
repository:addons-server Issue relating to addons-server
Milestone

Comments

@jvillalobos
Copy link

Part of #3477

The Add-on Visibility box on Status & Versions needs to be updated, since Listed / Unlisted won't be a global status anymore. UX for this is in #194.

The status sidebar (appearing above the navigation items on the left column) also needs to be updated. The UX discussion about this began in #193 (comment), but will be moved to a separate issue.

@eviljeff
Copy link
Member

My best guess on outstanding questions in #193 is in mozilla/addons-server#4005

@jvillalobos
Copy link
Author

After discussing with @wagnerand, I'd like to make some text changes to avoid developer confusion about what visible/invisible means. Here's my proposal:

  • Visible: visible to everyone on this site, and included in search results and listing pages.
  • Invisible: your add-on won't be included in search results, and its listing page will indicate you disabled it. New version submissions for listing won't be accepted in this state.

@eviljeff
Copy link
Member

New version submissions for listing won't be accepted in this state.

Is that true?

@jvillalobos
Copy link
Author

They won't be reviewed, so I would consider that as non-acceptance :). #3765 covers the actual blocking of those submissions.

@eviljeff
Copy link
Member

eviljeff commented Nov 21, 2016

I slightly modified to make the text consistent:

Visible: Visible to everyone on {0} and included in search results and listing pages.

Invisible: Hosted on {0}, but won't be included in search results, and its listing page will indicate you disabled it. New version submissions for listing won't be accepted in this state.

{0} is the site url, so addons.mozilla.org for prod.

@jvillalobos okay? Or should I drop the 'hosted on' part?

@jvillalobos
Copy link
Author

I removed the site name and 'hosted on' bits in the update because they were originally there to contrast with Unlisted, which is no longer there. I don't mind the Visible to everyone on {0}, but I'd rather not have Hosted on {0}.

@eviljeff
Copy link
Member

Invisible: Won't be included in search results, and its listing page will indicate you disabled it. New version submissions for listing won't be accepted in this state.

Or

Invisible: Your add-on won't be included in search results, and its listing page will indicate you disabled it. New version submissions for listing won't be accepted in this state.

I prefer the former as the 'Visible' text doesn't start with "Your add-on is visible..."

@jvillalobos
Copy link
Author

The first one is okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants