Stop setting addons with unlisted versions STATUS_NOMINATED or STATUS_PUBLIC #3996
Conversation
|
We do need something to prevent those add-ons from being shown as "Incomplete" in devhub though, right ? Maybe some check on |
|
mozilla/addons#3483 hides the status indicator for add-ons without listed versions. So this pull is either blocked on that (there are some outstanding Product/UX questions blocking) or we do a workaround for now that does the minimum to avoid developer confusion. |
|
Up to you. We need to remember that the same thing needs to be done in both the sidebar and the devhub index that list all your add-ons, though. |
|
it's the same template snippet 😃 |
|
sidebar done in #4005 (and my add-ons index though it looks less good) |
| 'addons.status NOT IN (%s, %s)' % ( | ||
| amo.STATUS_NULL, amo.STATUS_DISABLED) | ||
| 'addons.status NOT IN (%s)' % ( | ||
| amo.STATUS_DISABLED) |
There was a problem hiding this comment.
Could replace the IN now that there is only one value left.
eviljeff
force-pushed
the
unlisted-addon-is-null
branch
2 times, most recently
from
96c98fd
to
b151a4a
Compare
…_PUBLIC Also tidy up editors somewhat.
eviljeff
force-pushed
the
unlisted-addon-is-null
branch
from
b151a4a
to
75205c9
Compare
Also tidy up editors somewhat.
Part of mozilla/addons#3477