Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make current_version property only return versions in listed channel #3674

Closed
diox opened this issue Oct 24, 2016 · 4 comments
Closed

Make current_version property only return versions in listed channel #3674

diox opened this issue Oct 24, 2016 · 4 comments
Assignees
@diox
Labels
qa:not_needed repository:addons-server Issue relating to addons-server

Comments

@diox
Copy link
Member

diox commented Oct 24, 2016

Split from #3529

Once #3621 is done we'll need to tackle current_version property next. The plan is to make it point to the latest public listed version, and fix places where it's used for unlisted add-ons.

We might need to make some backwards-incompatible changes to the API as a result, since it exposes current_version, even for unlisted add-ons - at the very least if we keep the field without modifications it won't mean the same thing.
@diox diox self-assigned this Oct 24, 2016
@diox
Copy link
Member Author

diox commented Oct 24, 2016

I've got a branch which throws an exception in current_version property when it's accessed for an unlisted add-on, it's useful to find what's broken : https://travis-ci.org/diox/olympia/builds/170116338

@diox
Copy link
Member Author

diox commented Oct 24, 2016 •
edited

More thoughts on the API and what will happen once the is_listed flag is gone from add-ons and we have a mix of unlisted and listed versions:

  • The version list API need to change to filter by channel - filtering by listed channel by default, allowing owners/people with specific permissions to see all versions or only unlisted versions if requested.
  • With current_version in the add-on detail API pointing to the public listed version, clients wanting information about unlisted versions will need something else. Do we want to add something like latest_unlisted_version for only admins/reviewers/owners ? Would that be useful ? Same question for search results.

This was referenced Oct 28, 2016
Closed
Merged
Merged
Closed
diox referenced this issue in diox/olympia Nov 3, 2016
@diox
Refactor submit_finish() to avoid using {Addon}.current_version
cec2df8 
To prepare for #3847.

Bonus drive-by optimization, stop counting the add-ons for the user
when we're only interested in knowing if they have submitted any
other than the current one.
This was referenced Nov 3, 2016
Merged
Merged
Merged
@diox diox mentioned this issue Nov 10, 2016
Closed
13 tasks
@diox diox mentioned this issue Nov 14, 2016
Merged
diox referenced this issue in diox/olympia Nov 14, 2016
@diox
Make sure we only use current_version in "listed" context
4c6ef93 
Part of #3847, current_version will soon only consider listed versions
@diox
Copy link
Member Author

diox commented Nov 15, 2016

Fixed by mozilla/addons-server#3995

@diox diox closed this as completed Nov 15, 2016
@diox
Copy link
Member Author

diox commented Nov 15, 2016

Needs no QA because it's mostly an internal change. The user-facing changes are covered by different issues.

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added the repository:addons-server Issue relating to addons-server label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diox diox

Labels
qa:not_needed repository:addons-server Issue relating to addons-server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diox @KevinMind