Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Addon.latest_version #3621

Closed
4 tasks done
diox opened this issue Oct 13, 2016 · 2 comments
Closed
4 tasks done

Get rid of Addon.latest_version #3621

diox opened this issue Oct 13, 2016 · 2 comments
Assignees

Comments

@diox
Copy link
Member

diox commented Oct 13, 2016

Splitt from #3529

The latest_version field on Addon points to, well, the latest (non-disabled) version. It's used by reviewer tools to figure out which version to review, and internally so set a few things.

With the introduction of version channels, it won't be as useful, since you need to figure out the latest version available in the same channel you're interested in. We could add latest_unlisted_version and latest_listed_version fields, but that's probably overkill and won't scale if we decide to add more channels later.

I want to try to get rid of that field, replacing it with a method that takes a channel and maybe an optional argument to ignore disabled versions. To do this safely, my plan is to do this in 3 steps:

  • Keep the field and the methods that sets it, but stop using it directly, instead using latest_version property to emulate it, and modifying reviewer tools queries that directly hit the database
  • Then, replace latest_version property with a method using the channel
  • Then, stop setting the (now obsolete) field
  • Then, remove the column entirely.
@diox diox self-assigned this Oct 13, 2016
diox referenced this issue in diox/olympia Nov 16, 2016
Part of #3751

The column is kept for now because the migration is costly, but
since it's NULLable it should not be a problem. Deleting the
column is a follow-up task in the same issue.
@diox
Copy link
Member Author

diox commented Jan 6, 2017

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1328917 to let ops handle the column removal.

@eviljeff
Copy link
Member

eviljeff commented Feb 2, 2017

column is gone (on dev, stage, and prod today) so calling it done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants