Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Find Replacement feature to support non-AMO pages #4880

Closed
jvillalobos opened this issue Oct 9, 2017 · 4 comments · Fixed by mozilla/addons-server#6796
Closed

Expand Find Replacement feature to support non-AMO pages #4880

jvillalobos opened this issue Oct 9, 2017 · 4 comments · Fixed by mozilla/addons-server#6796
Assignees
Labels
Milestone

Comments

@jvillalobos
Copy link

The admin tool built in #4440 was designed to only point to AMO pages. However, some high-profile add-ons don't have good replacements because they have been replaced with existing Firefox features, so it will serve those users better to direct them to help pages (on SUMO, for instance).

Let's expand the admin tool to support non-AMO pages. Don't know if anything needs to be done about the redirect to work with external sites.

@jvillalobos
Copy link
Author

Looks like we'll be doing this via heartbeat instead.

@ValentinaPC
Copy link

Verified as fixed on AMO-dev FF56(Win 7).

Used legacy add-on: https://addons-dev.allizom.org/en-US/developers/addon/chatzilla/edit
Admin Tools settings and replacement:
https://addons-internal.dev.mozaws.net/en-US/admin/staff-models/addons/replacementaddon/
replacement-path
Redirection link:
https://addons-dev.allizom.org/find-replacement/?guid={59c81df5-4b7a-477b-912d-4e0fdf64e5f2}

Things seem to work as expected.

@eviljeff: please let me know if there is anything else I should check here.
Thanks!

@eviljeff
Copy link
Member

eviljeff commented Nov 1, 2017

lgtm

@ValentinaPC
Copy link

Marking this as verified-fixed.

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants