Don't error on invalid platform for search

[eviljeff]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1457707

A search such as https://addons.mozilla.org/en-US/firefox/search/?q=blah&platform=OpenFoo&appver=59.0.2 gives an error on new frontend because the API rejects "OpenFoo" as an invalid platform; on the legacy frontend the invalid platform is silently ignored and it falls back to All Platforms.

The fix is either:
a) Don't error in the addons-server API; interpret an unsupported platform parameter as 'All'
b) addons-frontend catches the API error and does something - e.g. redirects to https://addons.mozilla.org/en-US/firefox/search/?q=blah&appver=59.0.2
( c) wonfix )

[landryb]

'OpenFoo' is invalid, 'OpenBSD' is a valid platform, it's just that AMO only supports/cares about Tier1. I would be fine with fallbacking to All for non-tier1.

c) wontfix ? really ?

[jvillalobos]

Given the direction we're moving towards with WebExtensions, I think we should drop the platform parameter from the Add-ons Manager search (cc @ddurst). That doesn't address this issue for all existing clients, though.

I would favor (b), since I think the API should do the "right" thing as much as possible.

[diox]

I'm not sure how much that helps us yet, but we're moving towards dropping platform and just using applications - which would be firefox or android, and already in the URL (that's the part after the locale at the beginning).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

[landryb]

merge with #11563 ?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

[landryb]

@Stale: issue still stands.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

[jbeich]

Can someone tag this issue to avoid spam every 6 months? I can still reproduce on DragonFly (BSD).

addons/.github/stale.yml

Lines 14 to 22 in cc94359

	exemptLabels:
	- "contrib: maybe good first bug"
	- "contrib: good first bug"
	- "contrib: welcome"
	- "component: security"
	- "state: blocked"
	- "state: blocked by upstream"
	- "state: pull request ready"
	- "neverstale"

[eviljeff]

The issue is stale, regardless of the tags or status of it - no-one is working on it and it won't suddenly start being worked on anytime soon. If someone is willing to step up and contribute a fix then we can look at it, otherwise it may as well stay closed.

#708 (comment) pointed to the fix being b) so probably best to dupe this issue with #11563 anyway and work on it there.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.