Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop due_date on versions disabled and not signed #9131

Closed
diox opened this issue Mar 28, 2023 · 2 comments · Fixed by mozilla/addons-server#20546
Closed

Drop due_date on versions disabled and not signed #9131

diox opened this issue Mar 28, 2023 · 2 comments · Fixed by mozilla/addons-server#20546

Comments

@diox
Copy link
Member

diox commented Mar 28, 2023

Part of https://mozilla-hub.atlassian.net/browse/AMO-47

  • When a developer disables a version that isn't signed yet and has needs_human_review, the due date is removed.
  • When a developer re-enables a version that had needs_human_review, it gets a due date again.
  • When a developer deletes a version that isn't signed yet (internally this disables the files) and has needs_human_review, the due date is removed.
  • When a developer deletes an entire add-on, the due date should be removed on versions that aren't signed yet and have needs_human_review (internally all files would be disabled).
  • When a developer sets an add-on as "Invisible", the due date should be removed on listed versions that aren't signed yet and have needs_human_review (internally there should be a maximum of one listed version pending review at any given time, and when the add-on is made invisible the file would be disabled).

In all other cases involving needs_human_review the due date needs to stay regardless of what the developer does.

We currently keep due_date if a version that has needs_human_review is signed or non-deleted:
https://github.com/mozilla/addons-server/blob/c206243bfd5c240637115ececbba4725e95f58ed/src/olympia/versions/models.py#L207-L210

We actually want to keep due_date if a version that has needs_human_review is signed or non-disabled instead.

┆Issue is synchronized with this Jira Task

@ioanarusiczki
Copy link

ioanarusiczki commented Apr 3, 2023

@diox

I tested all the scenarios above and I think it's working as expected.

For the scenario when a developer makes an addon invisible and there are still unsigned versions -> these versions become unreviewed (disabled) and will remain in this state.

@KevinMind
Copy link
Contributor

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
@KevinMind KevinMind added repository:addons-server Issue relating to addons-server migration:2024 labels May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants