Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename CinderJob.decision_id column #9499

Closed
eviljeff opened this issue Mar 12, 2024 · 5 comments · Fixed by mozilla/addons-server#22000
Closed

rename CinderJob.decision_id column #9499

eviljeff opened this issue Mar 12, 2024 · 5 comments · Fixed by mozilla/addons-server#22000

Comments

@eviljeff
Copy link
Member

eviljeff commented Mar 12, 2024

#9497 will add a decision foreign key to CinderJob ... which means a decision_id column to hold the pk. But we already have a different (type charfield) column called decision_id. Lets rename it beforehand (actually create a new column and then copy the values across)

┆Issue is synchronized with this Jira Task

@ioanarusiczki
Copy link

@eviljeff

this qa not needed?

@eviljeff
Copy link
Member Author

@ioanarusiczki it should be a transparent change but to be sure, you can check you can start an appeal on a decision that was made before this change landed (2024-03-12 15:12) because that will verify the decision ids were correctly migrated.

@ioanarusiczki
Copy link

@eviljeff I've sent https://addons.allizom.org/en-US/abuse/appeal/54893/f9d81f48-4a7f-4ea4-a6ab-3586c32ee580/ , it's from Feb 27th but I didn't see the appeal in Stage Listings or the extension being flagged for review in rev tools.

So far I couldn't find another decision made before March 12th

@eviljeff
Copy link
Member Author

I found decision f9d81f48-4a7f-4ea4-a6ab-3586c32ee580 - it's was a decision on a user, at least according to cinder, and I see it in AMO Stage Users, so I think we're good.

@KevinMind
Copy link
Contributor

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants