"rename" CinderJob.decision_id to decision_cinder_id

[eviljeff]

fixes mozilla/addons#9499 - just renames the column from decision_id to decision_cinder_id.

[KevinMind]

Assuming we test this via CI but looks good to me.

[eviljeff]

Assuming we test this via CI but looks good to me.

yes, apart from the RunPython migration - as the test setup starts with an empty database it doesn't fully test the case of migrating existing data. But it's super trivial so it doesn't concern me.

If you did want to test this locally:

• you'd need at least one CinderJob with a decision_id set (would need either manually setting via django admin before the patch was checked out, or via db admin after)
• then run ./manage.py migrate abuse (or make update_db if you wanted to run all the migrations)
• check that CinderJob.decision_cinder_id now has the value that decision_id had.