Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make redux actions hot reloadable again #9860

Closed
kumar303 opened this issue Sep 20, 2016 · 2 comments · Fixed by mozilla/addons-frontend#5749
Closed

Make redux actions hot reloadable again #9860

kumar303 opened this issue Sep 20, 2016 · 2 comments · Fixed by mozilla/addons-frontend#5749
Assignees
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@kumar303
Copy link
Contributor

Describe the problem and steps to reproduce it:

Run a dev server with the react hot reloader enabled. Example:

npm run dev:amo

Change the code in any action creator.

What happened?

The old code is still running.

What did you expect to happen?

The hot reloader should automatically reload the action code so that you don't have to refresh the entire page and potentially lose your state.

Anything else we should know?

It looks like this was a regression in some upstream module but there are a couple different issues. See:

React Hot Loader 3.0 should fix this. Preview: gaearon/react-hot-boilerplate#61

@willdurand
Copy link
Member

Here is a patch for that: mozilla/addons-frontend@b5f49aa

See also this (minor) issue: mozilla/addons-frontend#5652 (comment)

@AlexandraMoga
Copy link

Please add STR or the label 'qa:not needed'
Thanks

@KevinMind KevinMind added migration:no-jira repository:addons-frontend Issue relating to addons-frontend labels May 5, 2024
@KevinMind KevinMind transferred this issue from mozilla/addons-frontend May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:not_needed repository:addons-frontend Issue relating to addons-frontend
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants