This repository has been archived by the owner on Feb 1, 2019. It is now read-only.
Warn about NewTabURL.override (bug 1200822) #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def NewTabURL_override(traverser): | ||
| def on_override(wrapper, arguments, traverser): | ||
| from validator.testcases.javascript.predefinedentities import ( | ||
| CUSTOMIZATION_API_HELP) |
There was a problem hiding this comment.
Why the import here and not at the top of the file? If it's to avoid an import loop, please add a comment saying so
|
Looks good to me (minor nit) |
mstriemer
force-pushed
the
NewTabURL.override-error-1200822
branch
from
a9f14d1
to
9e01a3e
Compare
mstriemer
added a commit
that referenced
this pull request
Sep 8, 2015
Warn about NewTabURL.override (bug 1200822)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1200822