Bug 1343708: Remove batch_incr #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were having problems where graphs weren't lining up. I did some work and theorized that since Antenna sends the same value a lot, that some of them were getting dropped during the "normalize for a flush interval" period. Thus I implemented batching of counters that occur often. Since then, I've learned a lot more about statsd and I think all those theories are rubbish. Given that the theories are rubbish and while in the bug comments I claim that batching helped, I don't think it actually did help at all and I think I was interpreting the data noise incorrectly. This commit removes the batching code because it's probably not actually helping at all and thus it's adding unneeded code complexity.
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having problems where graphs weren't lining up. I did some work and
theorized that since Antenna sends the same value a lot, that some of them were
getting dropped during the "normalize for a flush interval" period. Thus I
implemented batching of counters that occur often.
Since then, I've learned a lot more about statsd and I think all those theories
are rubbish.
Given that the theories are rubbish and while in the bug comments I claim that
batching helped, I don't think it actually did help at all and I think I was
interpreting the data noise incorrectly.
This commit removes the batching code because it's probably not actually helping
at all and thus it's adding unneeded code complexity.