This repository has been archived by the owner on Jan 9, 2019. It is now read-only.
Check nonce with Django cache (bug 963141) #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cache.set(key, True, | ||
| # We only need the nonce until the message itself expires. | ||
| # This also adds a little bit of padding. | ||
| timeout=settings.HAWK_MESSAGE_EXPIRATION + 5) |
There was a problem hiding this comment.
This prevents against replay attacks while the cache key is around, but once the cache has cleared, the nonce is available again, so that means you can replay once its expired... is that an issue?
There was a problem hiding this comment.
it shouldn't be an issue; a Hawk message has a timestamp which expires according to this setting I used. If the message expires, you couldn't replay it anyway, even if nonces weren't getting checked.
|
r+ then |
kumar303
added a commit
that referenced
this pull request
Feb 26, 2014
Check nonce with Django cache (bug 963141)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.