Skip to content

Commit

Permalink
For EXP-3625: Take getCoenrollingFeatureIds out of the interfaces
Browse files Browse the repository at this point in the history
  • Loading branch information
eliserichards committed Jul 10, 2023
1 parent 955aaa0 commit c2353d0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 36 deletions.
Expand Up @@ -182,13 +182,6 @@ interface NimbusInterface : FeaturesInterface, GleanPlumbInterface, NimbusEventS
*/
fun resetTelemetryIdentifiers() = Unit

/**
* Get a list of feature ids where the feature allows co-enrollment.
*
* @return A list of experiment ids that allow co-enrollment.
*/
fun getCoenrollingFeatureIds(): List<String> = listOf()

/**
* Control the opt out for all experiments at once. This is likely a user action.
*/
Expand Down
Expand Up @@ -644,29 +644,6 @@ class NimbusTests {

assertTrue(observed)
}

@Test
fun `test coenrolling features list is returned`() {
val expected = listOf("abc", "def", "ghi")
val observer = object : NimbusInterface.Observer {
override fun onUpdatesApplied(updated: List<org.mozilla.experiments.nimbus.internal.EnrolledExperiment>) {
runBlocking {
delay(250)
}
}
}
val nimbus = Nimbus(
context = context,
appInfo = appInfo,
coenrollingFeatureIds = expected,
server = null,
deviceInfo = deviceInfo,
observer = observer,
delegate = nimbusDelegate,
)

assertEquals(expected, nimbus.getCoenrollingFeatureIds())
}
}

// Mocking utilities, from mozilla.components.support.test
Expand Down
6 changes: 0 additions & 6 deletions components/nimbus/ios/Nimbus/NimbusApi.swift
Expand Up @@ -167,12 +167,6 @@ public protocol NimbusUserConfiguration {
/// - Returns A list of `AvailableExperiment`s
///
func getAvailableExperiments() -> [AvailableExperiment]

/// Get a list of feature ids where the feature allows co-enrollment.
///
/// - Returns A list of experiment ids that allow co-enrollment.
///
func getCoenrollingFeatureIds() -> [String]
}

public protocol NimbusEventStore {
Expand Down

0 comments on commit c2353d0

Please sign in to comment.