In Push Component, return scope as part of the decrypt() JSON response

[jrconlin]

According to

It's my understanding that since Scope is an identifier for service worker, (and since Push Component is not doing Delivery), decrypt should include the previously registered scope string as part of the response JSON. (Scope is a parameter of subscribe.

@jonalmeida can provide additional details if needed.

┆Issue is synchronized with this Jira Story

[jonalmeida]

Since scope is an identifier, we can be putting in multiple subscriptions with the same chid but different scopes, expecting separate subscriptions for each scope.

What I'm unsure about right now is if we should be using one chid for all GeckoView and multiple scopes, or just hashing the scope and using that as the chid? If the latter, then I guess we don't need scopes in the PushManager?

[jrconlin]

A CHID is basically how to determine the recipient of a push message on a given device. If you're fine with one recipient for all GeckoView push messages and use some other mechanism (e.g. an identifier in the body of the push message) then you shouldn't need scopes. Complicating things is that "scope" isn't contained in the received Push Message, since it's not provided to the Push server and encoded into the endpoint, nor is the endpoint provided to the decrypt function.

So possible solutions might include:

1. GeckoView creating a new subscription (new channelid + scope) per scope, in which case scope can be returned as part of the decrypt (this bug would cover a future PR to return a scope associated with a ChannelID as part of the decrypt response, who's return would also change.

2. GeckoView providing scope as part of the subscription info block to the subscription provider which would encode scope in the push message content

3. scope is incorporated into the endpoint information which may violate some privacy considerations and require work on the autopush server and push component.

[jonalmeida]

We spoke offline and reduced to a few points:

• There's not much difference between calling subscribe(hash_of_scope_to_uuid) and subscribe(hash_of_scope_to_uuid, scope). The scope is just stored in the database and not retrieved.
• What we can do as a client, is call subscribe(hash_of_scope_to_uuid, scope) and when we decrypt the message, return the SubscriptionResponse ([push] SubscriptionResponse needed when decrypting message #2047) and the scope together so that it can be passed on to GeckoView (which doesn't hold on the subscription info state).
• The GeckoView API for delivering a message is here¹.

[jrconlin]

Digging around the code for PushManager, I found PushManager.dispatchInfoForChid which returns DispatchInfo{ uaid: String, scope: String}

This might be what you're looking for.

[data-sync-user]

➤ Janet Dragojevic commented:

endofyear cleanup: is this still an issue that needs to be addressed?

[jonalmeida]

No, I think we have what we need. Thanks Janet!