Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[push] SubscriptionResponse needed when decrypting message #2047

Closed
jonalmeida opened this issue Oct 25, 2019 · 1 comment · Fixed by #2080
Closed

[push] SubscriptionResponse needed when decrypting message #2047

jonalmeida opened this issue Oct 25, 2019 · 1 comment · Fixed by #2080
Assignees
@jrconlin

Comments

@jonalmeida
Copy link
Collaborator

jonalmeida commented Oct 25, 2019 •
edited by data-sync-user
Loading

For WebPush, we need to provide the WebSubscription along with the decrypted data to GeckoView.

Right now, our hack for this is so call subscribe every time before a decrypt and then send those results together to the browser. It would be nice if we could get those together or be able to reconstruct them together.

The only missing information I can see that we need to construction a subscription is the scope, endpoint and appServerKey.

┆Issue is synchronized with this Jira Story
@jonalmeida jonalmeida changed the title [push] Subscription info needed when decrypting message [push] SubscriptionResponse needed when decrypting message Oct 30, 2019
@jonalmeida jonalmeida mentioned this issue Oct 30, 2019
Closed
@jrconlin
Copy link
Contributor

I forgot that there's PushManager.dispatchInfoForChid(chid) which currently returns scope and uaid. This function could be expanded to return those fields.

@rfk rfk added the 📣 Push label Oct 31, 2019
jrconlin added a commit that referenced this issue Oct 31, 2019
@jrconlin
feat: return endpoint and appServerKey in dispatch_info_for_chid()
ef88403 
* move mostly unused appServerKey from PushConfig to an optional string
in `subscribe()` (easier for customer to use)

* removed unused `regenerate_endpoints()` function.

Closes #2047
@jrconlin jrconlin self-assigned this Oct 31, 2019
@jrconlin jrconlin mentioned this issue Oct 31, 2019
Closed
jrconlin added a commit that referenced this issue Oct 31, 2019
@jrconlin
feat: return endpoint and appServerKey in dispatch_info_for_chid()
b0fae69 
* move mostly unused appServerKey from PushConfig to an optional string
in `subscribe()` (easier for customer to use)

* removed unused `regenerate_endpoints()` function.

Closes #2047
@jrconlin jrconlin mentioned this issue Oct 31, 2019
Merged
4 tasks
jrconlin added a commit that referenced this issue Nov 15, 2019
@jrconlin
feat: return endpoint and appServerKey in dispatch_info_for_chid() (#…
f12f43c 
…2080)

* feat: return endpoint and appServerKey in dispatch_info_for_chid()

* move mostly unused appServerKey from PushConfig to an optional string
in `subscribe()` (easier for customer to use)

* removed unused `regenerate_endpoints()` function.

* add hack to drop "empty" application keys

Closes #2047
@data-sync-user data-sync-user mentioned this issue Jul 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrconlin jrconlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: return endpoint and appServerKey in dispatch_info_for_chid() mozilla/application-services
3 participants
@rfk @jrconlin @jonalmeida