-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gradle to version 7.6.1 and Android Gradle Plugin to 7.4.1 #5401
Conversation
Codecov ReportBase: 46.24% // Head: 46.24% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #5401 +/- ##
=======================================
Coverage 46.24% 46.24%
=======================================
Files 172 172
Lines 14252 14252
=======================================
Hits 6591 6591
Misses 7661 7661 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This looks good AFAICT. The only CI bustage is broken Fenix builds due to #5406. That said, I must confess that I don't claim to fully understand the implications of the JVM 11 bytecode change even if everything does appear to be green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc If Fenix+Focus are updated to this version as well I don't see a problem with upgrading it.
I would request though that we add a changelog entry as a breaking change noting that the jvm compat target is now 11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with @jeddai's request to add a changelog entry satisfied.
2f04663
to
436e8c6
Compare
AC/Fenix/Focus bump has landed in mozilla-mobile/firefox-android#732. |
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[ff-android: firefox-android-branch-name]
and/or[fenix: fenix-branch-name]
to the PR title.