Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to version 7.6.1 and Android Gradle Plugin to 7.4.1 #5401

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

rvandermeulen
Copy link
Contributor

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [ff-android: firefox-android-branch-name] and/or [fenix: fenix-branch-name] to the PR title.

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Base: 46.24% // Head: 46.24% // No change to project coverage 👍

Coverage data is based on head (2f04663) compared to base (b3d34a8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5401   +/-   ##
=======================================
  Coverage   46.24%   46.24%           
=======================================
  Files         172      172           
  Lines       14252    14252           
=======================================
  Hits         6591     6591           
  Misses       7661     7661           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rvandermeulen rvandermeulen changed the title Update Gradle to version 7.6.1 and Android Gradle Plugin to 7.4.1 [ci full] [ff-android: main] Update Gradle to version 7.6.1 and Android Gradle Plugin to 7.4.1 Feb 24, 2023
@rvandermeulen rvandermeulen marked this pull request as ready for review February 24, 2023 21:26
@rvandermeulen
Copy link
Contributor Author

This looks good AFAICT. The only CI bustage is broken Fenix builds due to #5406. That said, I must confess that I don't claim to fully understand the implications of the JVM 11 bytecode change even if everything does appear to be green.

@rvandermeulen rvandermeulen changed the title Update Gradle to version 7.6.1 and Android Gradle Plugin to 7.4.1 Update Gradle to version 7.6.1 and Android Gradle Plugin to 7.4.1 [firefox-android: main] Feb 25, 2023
@rvandermeulen rvandermeulen changed the title Update Gradle to version 7.6.1 and Android Gradle Plugin to 7.4.1 [firefox-android: main] Update Gradle to version 7.6.1 and Android Gradle Plugin to 7.4.1 Feb 25, 2023
@Dexterp37 Dexterp37 requested review from travis79 and removed request for Dexterp37 February 27, 2023 10:55
Copy link
Member

@jeddai jeddai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc If Fenix+Focus are updated to this version as well I don't see a problem with upgrading it.

I would request though that we add a changelog entry as a breaking change noting that the jvm compat target is now 11

Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with @jeddai's request to add a changelog entry satisfied.

@rvandermeulen
Copy link
Contributor Author

AC/Fenix/Focus bump has landed in mozilla-mobile/firefox-android#732.

@rvandermeulen rvandermeulen merged commit ed70b4f into main Mar 2, 2023
@rvandermeulen rvandermeulen deleted the gradle_7.6.1 branch March 2, 2023 17:13
@jeddai jeddai mentioned this pull request Mar 8, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants