Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

history: Sync can insert multiple copies of the same visit, just with different values for is_local #634

Closed
thomcc opened this issue Feb 7, 2019 · 1 comment
Closed

history: Sync can insert multiple copies of the same visit, just with different values for is_local #634

thomcc opened this issue Feb 7, 2019 · 1 comment
Milestone
History API - v1

Comments

@thomcc
Copy link
Contributor

thomcc commented Feb 7, 2019

Saw this while testing #632. If sync already has a local visit, it will add a new 'remote' version of the visit regardless while applying. This happens regardless of sync status.
thomcc pushed a commit that referenced this issue Feb 8, 2019
Avoid inserting history visits that already exist when syncing. Fixes #…
2276c67 
…634
@thomcc
Copy link
Contributor Author

thomcc commented Feb 8, 2019

I fixed this in that patch set because

  • It's actually pretty easy now that we're skipping tombstones
  • That patch set is the first time it would be made visible.

thomcc pushed a commit that referenced this issue Feb 8, 2019
Avoid inserting history visits that already exist when syncing. Fixes #…
4c68d51 
…634
thomcc pushed a commit that referenced this issue Feb 8, 2019
Avoid inserting history visits that already exist when syncing. Fixes #…
5be0c7d 
…634
thomcc pushed a commit that referenced this issue Feb 8, 2019
Avoid inserting history visits that already exist when syncing. Fixes #…
2d739b5 
…634
thomcc pushed a commit that referenced this issue Feb 8, 2019
Avoid inserting history visits that already exist when syncing. Fixes #…
6be87da 
…634
thomcc pushed a commit that referenced this issue Feb 8, 2019
Avoid inserting history visits that already exist when syncing. Fixes #…
3b707b0 
…634
thomcc pushed a commit that referenced this issue Feb 8, 2019
Avoid inserting history visits that already exist when syncing. Fixes #…
1fd6010 
…634
@rfk rfk added this to the History API - v1 milestone Feb 12, 2019
thomcc pushed a commit that referenced this issue Feb 13, 2019
Avoid inserting history visits that already exist when syncing. Fixes #…
43302b1 
…634
thomcc pushed a commit that referenced this issue Feb 13, 2019
Avoid inserting history visits that already exist when syncing. Fixes #…
2553d90 
…634
@thomcc thomcc closed this as completed in 6fb2a2c Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
History API - v1
Development

No branches or pull requests
2 participants
@rfk @thomcc