Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a getBookmarksWithKeyword() API #953

Closed
justindarc opened this issue Apr 11, 2019 · 6 comments · Fixed by #1345
Closed

Expose a getBookmarksWithKeyword() API #953

justindarc opened this issue Apr 11, 2019 · 6 comments · Fixed by #1345

Comments

@justindarc
Copy link
Contributor

justindarc commented Apr 11, 2019 •
edited by cse-test-sync

Firefox for iOS previously had support for bookmarks keyword searches in the AwesomeBar. To continue to support this, we will need the following API:

getBookmarksWithKeyword(keyword: String) -> [BookmarkItem]

┆Issue is synchronized with this Jira Story
@justindarc justindarc mentioned this issue Apr 11, 2019
Closed
@thomcc
Copy link
Contributor

thomcc commented Apr 11, 2019

We don't support keywords really, although maybe we should. (We have support for syncing them, so it's not like we're completely oblivious to them)

CC @linacambridge @mhammond

@mhammond
Copy link
Member

I think the main reason we haven't supported them is that desktop plans on moving away from keywords - although I can't find a bug to back that up. I believe @linacambridge knows more about this so hopefully she'll chime in.

@justindarc
Copy link
Contributor Author

We're gonna have like 3(?) users on iOS that are gonna be sad to hear that.

In all seriousness, this isn't the most important thing for us right now. I've simply just disabled that code for the time being. If desktop removes support for it, we'll just drop it.

@thomcc
Copy link
Contributor

thomcc commented Apr 15, 2019

I think @davismtl has indicated that the rumors about bookmark keywords going away in desktop had been exaggerated

@davismtl
Copy link

Correct. I don't think they are going anywhere soon. (per what I heard from other product managers)
And... Dcamp said "over his dead body". So... lots' of uncertainty for now.

@rfk
Copy link
Contributor

rfk commented Apr 15, 2019

Dcamp said "over his dead body". So... lots' of uncertainty for now.

I dunno, that sounds like the opposite of uncertainty to me ;-)

linabutler added a commit that referenced this issue May 30, 2019
@linabutler
Add a getBookmarkURLForKeyword API for iOS.
1f9a7b5 
Rust Places doesn't support setting keywords for URLs, and it's unclear
if we'll ever port keywords as they exist on Desktop today. However,
we do sync and round-trip keywords set on Desktop, so we can read them
directly from the `moz_bookmarks_synced` table.

Closes #953.
@thomcc thomcc added good-second-issue Good for contributors, but not necessarially good for newcomers, as they tend to be more involved. and removed good-second-issue Good for contributors, but not necessarially good for newcomers, as they tend to be more involved. labels Jun 9, 2019
@farhanpatel farhanpatel mentioned this issue Jun 25, 2019
Closed
@tinoism tinoism mentioned this issue Jul 1, 2019
Merged
tinoism pushed a commit to tinoism/application-services that referenced this issue Jul 24, 2019
@linabutler @tinoism
Add a getBookmarkURLForKeyword API for iOS.
d2a4d92 
Rust Places doesn't support setting keywords for URLs, and it's unclear
if we'll ever port keywords as they exist on Desktop today. However,
we do sync and round-trip keywords set on Desktop, so we can read them
directly from the `moz_bookmarks_synced` table.

Closes mozilla#953.
tinoism pushed a commit to tinoism/application-services that referenced this issue Jul 24, 2019
@linabutler @tinoism
Add a getBookmarkURLForKeyword API for iOS.
04035f8 
Rust Places doesn't support setting keywords for URLs, and it's unclear
if we'll ever port keywords as they exist on Desktop today. However,
we do sync and round-trip keywords set on Desktop, so we can read them
directly from the `moz_bookmarks_synced` table.

Closes mozilla#953.
tinoism pushed a commit to tinoism/application-services that referenced this issue Jul 25, 2019
@linabutler @tinoism
Add a getBookmarkURLForKeyword API for iOS.
ea12bb4 
Rust Places doesn't support setting keywords for URLs, and it's unclear
if we'll ever port keywords as they exist on Desktop today. However,
we do sync and round-trip keywords set on Desktop, so we can read them
directly from the `moz_bookmarks_synced` table.

Closes mozilla#953.
tinoism pushed a commit to tinoism/application-services that referenced this issue Jul 25, 2019
@linabutler @tinoism
Add a getBookmarkURLForKeyword API for iOS.
faaa8ab 
Rust Places doesn't support setting keywords for URLs, and it's unclear
if we'll ever port keywords as they exist on Desktop today. However,
we do sync and round-trip keywords set on Desktop, so we can read them
directly from the `moz_bookmarks_synced` table.

Closes mozilla#953.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add and expose a getBookmarkURLForKeyword API. tinoism/application-services
6 participants
@rfk @mhammond @vladikoff @justindarc @thomcc @davismtl