Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LocalizedError and not Error in swift, and override errorDescription #1323

Merged
merged 2 commits into from Jun 25, 2019

Conversation

thomcc
Copy link
Contributor

@thomcc thomcc commented Jun 25, 2019

This make the firefox-ios sentry errors a little easier to deal with.

Fixes #853.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • cargo test --all produces no test failures
    • cargo clippy --all --all-targets --all-features runs without emitting any warnings
    • cargo fmt does not produce any changes to the code
    • ./gradlew ktlint detekt runs without emitting any warnings
    • swiftformat --swiftversion 4 megazords components/*/ios && swiftlint runs without emitting any warnings or producing changes
    • Note: For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@thomcc thomcc requested a review from garvankeeley June 25, 2019 17:33
Copy link
Contributor

@garvankeeley garvankeeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thousand thank yous for putting up with the verbosity of Swift custom error type descriptions.

@nolanamy
Copy link

nolanamy commented Sep 4, 2020

All my Sentry errors looked like "The operation couldn’t be completed..."

A thousand thank yous for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error messages not coming through on iOS
3 participants