Upgrade to Android NDK r20 [ci full] #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eoger
force-pushed
the
upgrade-ndk
branch
3 times, most recently
from
dbf88c4
to
de73733
Compare
|
Asking for review: Even though this is not required right now to unblock people's work, I believe we could avoid a lot of pain in the future and pay a little bit of technical debt by using a newer NDK. |
thomcc
approved these changes
Oct 2, 2019
| @@ -20,7 +20,7 @@ fi | |||
|
|
|||
| if [[ -z "${ANDROID_NDK_ROOT}" ]]; then | |||
| echo "Could not find Android NDK:" | |||
| echo 'Please install the Android NDK r15c and then set ANDROID_NDK_ROOT.' | |||
| echo 'Please install Android NDK r20 and then set ANDROID_NDK_ROOT.' | |||
There was a problem hiding this comment.
Should we check that it's r20 somehow? Seems very likely people will miss the memo to update this...
Probably worth sending out an email too, tbh.
There was a problem hiding this comment.
We actually check a bit further down the file :)
There was a problem hiding this comment.
Good idea on the email!
vladikoff
approved these changes
Oct 2, 2019
vladikoff
approved these changes
Oct 2, 2019
vladikoff
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1029.
Fixes #1913.
Fixes #1912.
This will need thorough testing as it might break stuff subtly on different Android architectures.