Add BridgedEngine to sync15-traits #2970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1626128 / https://jira.mozilla.com/browse/SYNC-1033
Last commit might be all we need to do for https://bugzilla.mozilla.org/show_bug.cgi?id=1628892 / https://jira.mozilla.com/browse/SYNC-1088
I also renamed
interrupt
tosaci-interrupt
and made it manually implement errors. Failure is a really slow dependency to compile, and saved us like 5 lines, and also this is a dep very specific to our team and so it kinda should reflect that (I've always kind of hated how broad it's name was). I usedsaci-
overas-
since the latter is an english word.Pull Request checklist
automation/all_tests.sh
runs to completion and produces no failures[ci full]
to the PR title.