Add failing testcases to reproduce issue #3365. #3375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
pushcomponent has anextract_valuehelper function that tries to parse a single item out of a HTTP header using the common "key=value; key=value" syntax.Parsing such headers is fraught with peril. Here are two small testcases for things that we don't currently handle correctly, one of which apears to be the cause of #3364 and #3365 (I added a bunch of
panic!s in here to confirm that it was failing with the same error messages as seen in those issues).I don't have any more time to spend on this issue so I haven't worked on a fix, but I'm pushing them in the hope that they can be a starting point when those issues make it to the top of someone's stack.
Connects to #3365.