Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Nimbus FML CLI to only import R when it is required #5361

Merged
merged 9 commits into from Feb 10, 2023

Conversation

jeddai
Copy link
Member

@jeddai jeddai commented Feb 3, 2023

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [ff-android: firefox-android-branch-name] and/or [fenix: fenix-branch-name] to the PR title.

@jeddai jeddai force-pushed the fix-import-r-when-not-required branch from 4085b54 to d5d6036 Compare February 3, 2023 19:39
@jhugman jhugman self-requested a review February 7, 2023 13:18
@jeddai jeddai marked this pull request as ready for review February 8, 2023 14:57
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've r+'d here. There are some comments, but I've added suggestions for all of them.

Thanks!

@jeddai jeddai closed this Feb 9, 2023
@jeddai jeddai reopened this Feb 9, 2023
@jeddai jeddai closed this Feb 9, 2023
@jeddai jeddai reopened this Feb 9, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 46.44% // Head: 46.44% // No change to project coverage 👍

Coverage data is based on head (c2ff14b) compared to base (a812bfa).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5361   +/-   ##
=======================================
  Coverage   46.44%   46.44%           
=======================================
  Files         169      169           
  Lines       14343    14343           
=======================================
  Hits         6661     6661           
  Misses       7682     7682           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeddai jeddai merged commit bd5ff1a into mozilla:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants