New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Nimbus FML CLI to only import R when it is required #5361
Conversation
4085b54
to
d5d6036
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've r+'d here. There are some comments, but I've added suggestions for all of them.
Thanks!
components/support/nimbus-fml/src/backends/kotlin/gen_structs/bundled.rs
Outdated
Show resolved
Hide resolved
components/support/nimbus-fml/src/backends/kotlin/gen_structs/mod.rs
Outdated
Show resolved
Hide resolved
components/support/nimbus-fml/src/backends/kotlin/gen_structs/bundled.rs
Outdated
Show resolved
Hide resolved
components/support/nimbus-fml/src/backends/kotlin/gen_structs/bundled.rs
Outdated
Show resolved
Hide resolved
…bundled.rs Co-authored-by: jhugman <jhugman@users.noreply.github.com>
Codecov ReportBase: 46.44% // Head: 46.44% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #5361 +/- ##
=======================================
Coverage 46.44% 46.44%
=======================================
Files 169 169
Lines 14343 14343
=======================================
Hits 6661 6661
Misses 7682 7682 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Pull Request checklist
[ci full]
to the PR title.Branch builds: add
[ff-android: firefox-android-branch-name]
and/or[fenix: fenix-branch-name]
to the PR title.