Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update merge_feature_defaults to error on invalid property keys #5620

Merged
merged 4 commits into from Jun 5, 2023

Conversation

jeddai
Copy link
Member

@jeddai jeddai commented May 30, 2023

https://mozilla-hub.atlassian.net/browse/EXP-3503

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@jeddai jeddai added nimbus Nimbus, the experimentation platform. rust Pull requests that update Rust code labels May 30, 2023
@jeddai jeddai requested a review from jhugman May 31, 2023 13:37
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

components/support/nimbus-fml/src/error.rs Outdated Show resolved Hide resolved
@jeddai jeddai enabled auto-merge June 5, 2023 15:34
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 96.72% and project coverage change: +0.27 🎉

Comparison is base (d43fbb3) 84.11% compared to head (831c988) 84.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5620      +/-   ##
==========================================
+ Coverage   84.11%   84.39%   +0.27%     
==========================================
  Files         106      106              
  Lines       11042    11092      +50     
==========================================
+ Hits         9288     9361      +73     
+ Misses       1754     1731      -23     
Impacted Files Coverage Δ
components/support/nimbus-fml/src/error.rs 15.15% <50.00%> (+2.24%) ⬆️
components/support/nimbus-fml/src/parser.rs 95.13% <96.29%> (-0.01%) ⬇️
...port/nimbus-fml/src/intermediate_representation.rs 96.53% <100.00%> (+2.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeddai jeddai added this pull request to the merge queue Jun 5, 2023
Merged via the queue into mozilla:main with commit 3630ef2 Jun 5, 2023
16 checks passed
@jeddai jeddai deleted the fix-error-on-invalid-property-keys branch June 5, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nimbus Nimbus, the experimentation platform. rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants